On 13/02/2019 14:29, Andrew Lunn wrote: >> So we have these modes: >> >> PHY_INTERFACE_MODE_RGMII: TX and RX delays disabled >> PHY_INTERFACE_MODE_RGMII_ID: TX and RX delays enabled >> PHY_INTERFACE_MODE_RGMII_RXID: RX delay enabled, TX delay disabled >> PHY_INTERFACE_MODE_RGMII_TXID: TX delay enabled, RX delay disabled >> >> What I don't like with this patch, is that if we specify phy-mode >> PHY_INTERFACE_MODE_RGMII_TXID, this patch will enable TX delay, >> but RX delay will not be explicitly set. > > That is not the behaviour we want. It is best to assume the device is > in a random state, and correctly enable/disable all delays as > requested. Only leave the hardware alone if PHY_INTERFACE_MODE_NA is > used. That's what my patch did: https://www.spinics.net/lists/netdev/msg445053.html But see Florian's remarks: https://www.spinics.net/lists/netdev/msg445133.html Regards.
