Hi Brian! On Fri, Jan 25, 2019 at 5:23 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > The probing of this driver calls platform_irq_count, which will > setup all of the IRQs that are configured in device tree. In > preparation for converting this driver to be a hierarchical IRQ > chip, hardcode the IRQ count based on the hardware type so that all > the IRQs are not configured immediately and are configured on an > as-needed basis later in the boot process. This change will also > allow for the removal of the interrupts property later in this > patch series once the hierarchical IRQ chip support is in. > > This patch also removes the generic qcom,ssbi-gpio OF match since we > don't know the number of pins. All of the existing upstream bindings > already include the more-specific binding. > > This change was not tested on any actual hardware, however the same > change was made to spmi-gpio and tested on a LG Nexus 5 (hammerhead) > phone. > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> I found a bug here: > - pctrl->dev = &pdev->dev; Do not delete this line. Subsequent code makes heavy use of pctrl->dev and crashes. After fixing this I get other crashes :D but those are from other patches so I try to locate those problems too. Yours, Linus Walleij
