Hello, This series is now good enough for the limelight, IMO. Difference between, v2 and v3: - Add qcom,msm8998-qmp-ufs-phy compat string and match it in the PHY driver - Drop vdd-hba-fixed-regulator - Write the reg addresses with full 32-bit width - Set regulator-allow-set-load only on the 3 rails used by UFS. - Revert the patch introducing ufshcd_set_vccq_rail_unused Difference between v1 and v2: - New patch to add 'regulator-allow-set-load' prop to all vreg nodes - Rename rpmcc node to 'clock-controller' + Add Review tags - Drop UFS pinctrl gymnastics (not required, probably left enabled in bootloader) - Delete GCC_UFS_ICE_CORE_CLK (ICE not used upstream, I think) - Fix sizes of ufsphy register areas based on Jeffrey's feedback - Hack ufshcd_set_vccq_rail_unused into a NOP to work around lock up + reboot Marc Gonzalez (5): arm64: dts: qcom: msm8998: Add UFS nodes arm64: dts: qcom: msm8998: Allow drivers to set-load dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-ufs-phy phy: qcom-qmp: Add QMP UFS PHY support for msm8998 Revert "scsi: ufs: disable vccq if it's not needed by UFS device" .../devicetree/bindings/phy/qcom-qmp-phy.txt | 1 + arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 22 +++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 63 +++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp.c | 3 + drivers/scsi/ufs/ufs.h | 1 - drivers/scsi/ufs/ufshcd.c | 59 ++--------------- 6 files changed, 93 insertions(+), 56 deletions(-) -- 2.17.1