On Thu, Jan 24, 2019 at 5:54 PM Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> wrote: > > Hi Alex, > > Thanks for the review! > > On 1/24/19 10:43 AM, Alexandre Courbot wrote: > > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > > <stanimir.varbanov@xxxxxxxxxx> wrote: > >> > >> This adds three more helper functions: > >> * for internal buffers reallocation, applicable when we are doing > >> dynamic resolution change > >> * for initial buffer processing of capture and output queue buffer > >> types > >> > >> All of them will be needed for stateful Codec API support. > >> > >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > >> --- > >> drivers/media/platform/qcom/venus/helpers.c | 82 +++++++++++++++++++++ > >> drivers/media/platform/qcom/venus/helpers.h | 2 + > >> 2 files changed, 84 insertions(+) > >> > >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > >> index f33bbfea3576..637ce7b82d94 100644 > >> --- a/drivers/media/platform/qcom/venus/helpers.c > >> +++ b/drivers/media/platform/qcom/venus/helpers.c > >> @@ -322,6 +322,52 @@ int venus_helper_intbufs_free(struct venus_inst *inst) > >> } > >> EXPORT_SYMBOL_GPL(venus_helper_intbufs_free); > >> > >> +int venus_helper_intbufs_realloc(struct venus_inst *inst) > > > > Does this function actually reallocate buffers? It seems to just free > > what we had previously. > > The function free all internal buffers except PERSIST. After that the > buffers are allocated in intbufs_set_buffer function (I know that the > function name is misleading). Yeah, that's what I felt - do you think you can fix this for clarity?
