Hi, On Mon, Jan 7, 2019 at 10:52 AM Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote: > >> + compatible = "qcom,sdm845-pdc"; > >> + reg = <0xb220000 0x30000>; > > > >nit: apparently common practice for Quaclomm dts is to pad the address > >in the "reg" field to all 8 digits. So the above should be: > > > >reg = <0x0b220000 0x30000>; > > > >NOTE: it's important to _not_ pad the unit address in the node name > >(so you got that right). Only update the "reg". For context: > > > Ok. > > Will take care of these in the next spin. This will now need to be adjusted to: reg = <0 0x0b220000 0 0x30000>; This fixes things up to deal with the patch ("arm64: dts: qcom: sdm845: Increase address and size cells for soc"), AKA: - https://patchwork.kernel.org/patch/10767511/ - https://lkml.kernel.org/r/20190117042940.25487-2-bjorn.andersson@xxxxxxxxxx Thanks! -Doug