Hello, After weeks (literally!) of poking the system at random, Jeffrey found why UFS refused to work on APQ8098: we were not setting the load on the vregs. Difference between v1 and v2: - New patch to add 'regulator-allow-set-load' prop to all vreg nodes - Rename rpmcc node to 'clock-controller' + Add Review tags - Drop UFS pinctrl gymnastics (not required, probably left enabled in bootloader) - Delete GCC_UFS_ICE_CORE_CLK (ICE not used upstream, I think) - Fix sizes of ufsphy register areas based on Jeffrey's feedback - Hack ufshcd_set_vccq_rail_unused into a NOP to work around lock up + reboot Marc Gonzalez (4): arm64: dts: qcom: msm8998: Add rpmcc node arm64: dts: qcom: msm8998: Add UFS nodes Add regulator-allow-set-load ufshcd_set_vccq_rail_unused locks up the board arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 52 +++++++++++++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 69 +++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 1 + 3 files changed, 122 insertions(+) -- 2.17.1