Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
- Subject: Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2
- From: saiprakash.ranjan@xxxxxxxxxxxxxx
- Date: Sat, 12 Jan 2019 18:03:57 +0530
- Cc: Mark Rutland <mark.rutland@xxxxxxx>, devicetree@xxxxxxxxxxxxxxx, Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>, Suzuki K Poulose <suzuki.poulose@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, David Brown <david.brown@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Sibi Sankar <sibis@xxxxxxxxxxxxxx>, Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>, Leo Yan <leo.yan@xxxxxxxxxx>, Andy Gross <andy.gross@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- In-reply-to: <20190111185242.GB22691@xps15>
- References: <cover.1547054308.git.saiprakash.ranjan@codeaurora.org> <4cb23e3bc414f3a1cac555d27b93e7e8cfeb68c9.1547054308.git.saiprakash.ranjan@codeaurora.org> <20190111185242.GB22691@xps15>
- User-agent: Roundcube Webmail/1.2.5
Hi Mathieu,
I think it would be better to simply mask out the minor version number
bits in
function etm4_arch_supported(). That way we can add more intelligence
in there
in the future if we have to and we don't have to touch the calling code
again.
Thanks for the review. Yes it seems good, I will make this change in
next version of the patch.
- Sai
[Index of Archives]
[Linux ARM Kernel]
[Linux ARM]
[Linux Omap]
[Fedora ARM]
[Linux for Sparc]
[IETF Annouce]
[Security]
[Bugtraq]
[Linux MIPS]
[ECOS]
[Asterisk Internet PBX]
[Linux API]