On Mon, Jan 7, 2019 at 3:11 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > pmic_spmi_probe calls devm_of_platform_populate, which traverses all > of the children in device tree from the parent down to the children, > grandchildren, etc. of_irq_count is called on most of the nodes (via > of_device_alloc) and this initializes all of the IRQs. Further along in > the boot process, spmi-gpio is initialized as a hierarchical IRQ chip > in a later patch (with spmi-arb as the parent IRQ domain), and the same > hwirq is now associated with two Linux virqs and IRQs will not work as > expected. Correct this issue by using devm_mfd_add_devices to initialize > just the children so that IRQs are initialized on an as-needed basis. > > This patch also selects CONFIG_MFD_CORE since this is required by > devm_mfd_add_devices. > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> Good catch! Now I see why this was acting so weird for you. Also the MFD semantics are standardized and make much more sense after this. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> I suppose Lee can merge this in orthogonal in the MFD tree, the end result will be functional after the v5.1 merge window. I think I should also fix qcom-pm8xxx after this, as well as the similar SSBI code for elder platforms. Yours, Linus Walleij
