On Fri, Jan 04, 2019 at 04:25:23PM -0800, Stephen Boyd wrote: > > + /* > > + * Check to see if the hwirq is already associated with another virq on > > + * this IRQ domain. If so, then disassociate it before associating the > > + * hwirq with the new virq. IRQs are all initially setup without an IRQ > > + * hierarchy when this driver is probed and when mfd/qcom-spmi-pmic.c is > > + * probed. Later in the boot process, an IRQ hierarchy is requested by > > + * pinctrl-spmi-gpio.c, and the same hwirq is now associated with a new > > + * virq. > > Is that because we count the irqs in the pmic gpio driver? Yes. The call to devm_of_platform_populate() in drivers/mfd/qcom-spmi-pmic.c also triggers this condition. I'll experiment with this some more this weekend. > Otherwise patch looks good to me. Thanks for working on this. Are you > going to convert the ssbi master and gpio chip too? Yes, I will do that work as well once this patch series is accepted. I currently don't have the hardware to test it, but I'm willing to pick up a cheap device on ebay. Any suggestions for something that boots a mainline kernel with the ssbi? It looks like the Sony Xperia Z phone is one of the supported devices. Thanks for your review on the other patches. It all makes sense. Brian
