On 20/12/2018 16:49, Ulf Hansson wrote: [ ... ] >>> +#ifdef CONFIG_CPU_IDLE >> >> It would be nicer if you can remove the CONFIG_CPU_IDLE by replacing it >> with a specific one (eg. CONFIG_PSCI_IDLE) and make it depend on >> CONFIG_CPU_IDLE, so the config options stay contained in their >> respective subsystems directory. > > I am all for simplifying the Kconfig options in here, as indeed it's > rather messy. However, I would rather avoid folding in additional > cleanup changes to this series, is already extensive enough. > > Would you be okay if we deal with that on top? IMO, there are patches in this series which can be grouped into a cleanup + set the scene patchset and merged immediately. An option similar to ARM_SCMI_POWER_DOMAIN can be part of it. However, if you swear you will do the change after and sign with your blood, I'm fine with that 0:) -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog