Hi,
On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote:
>
> 'interrupt-names' shouldn't be used in cases when there is only
> one interrupt and it is not otherwise used in the driver.
>
> Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 1 -
> 1 file changed, 1 deletion(-)
Looks good to me. It should be noted that Andy shouldn't land this
until he has a tree that contains ("drm/msm/gpu: Remove hardcoded
interrupt name"). ...or he should Ack this and it should go through
the same tree as that patch.
I'm curious: is there a reason you didn't remove it from the other two users?
linuxnext/master:arch/arm/boot/dts/imx51.dtsi:
interrupt-names = "kgsl_3d0_irq";
linuxnext/master:arch/arm/boot/dts/imx53.dtsi:
interrupt-names = "kgsl_3d0_irq";
...also: if this really is only for "apq8064" and not globally for all
qcom devices it'd be nice to mention "apq8064" somewhere in the
subject.
-Doug
