Quoting Govind Singh (2018-12-15 02:35:51) > Add device tree bindings for WiFi QDSP subsystem clock controls > found in OCS405 soc. > > Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> It was? > diff --git a/Documentation/devicetree/bindings/clock/qcom,wcsscc.txt b/Documentation/devicetree/bindings/clock/qcom,wcsscc.txt > new file mode 100644 > index 000000000000..2b19ef0b5689 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,wcsscc.txt > @@ -0,0 +1,26 @@ > +Qualcomm WCSS Clock Controller Binding > +----------------------------------------------- > + > +Required properties : > +- compatible : shall contain "qcom,qcs404-wcsscc" > +- #clock-cells : from common clock binding, shall contain 1. Drop the full-stop please. > +- reg : shall contain base register address and size, > + in the order > + Index-0 maps to WCSS_Q6SSTOP clocks register region > + Index-1 maps to WCSS_TCSR register region > + Index-2 maps to WCSS_QDSP6SS register region > + Index 0, Index 1, Index 2? Not sure why there's a hyphen there. > +Optional properties : > +- reg-names : register names of WCSS domain > + "wcss_q6sstop", "wcnss_tcsr", "wcss_qdsp6ss". > + > +Example: > +The below node has to be defined in the cases where the WCSS peripheral loader > +would bring the subsystem out of reset. > + > + clock_wcsscc: qcom,wcsscc@7000000 { clock-controller@7000000 > + compatible = "qcom,qcs404-wcsscc"; > + reg = <0x07500000 0x4e000>, <0x07550000 0x8012>, <0x07400000 0x104>; And then that unit address doesn't match the first offset so that needs fixing too. > + reg-names = "wcss_q6sstop", "wcnss_tcsr", "wcss_qdsp6ss"; > + #clock-cells = <1>; > + };