Hi, On Thu, Oct 25, 2018 at 9:38 AM Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote: > @@ -142,6 +148,9 @@ int llcc_slice_activate(struct llcc_slice_desc *desc) > int ret; > u32 act_ctrl_val; > > + if (IS_ERR(drv_data)) > + return PTR_ERR(drv_data); > + There's a conflict with your other patch in commit ff49a5198fc1 ("FROMLIST: soc: qcom: llcc-slice: Add error checks for API functions") right here. Maybe you should send a v2? Presumably patch #3 in this series would be dropped since there was some controversy over it? -Doug