On Fri, Nov 30, 2018 at 11:06:53AM +0000, Russell King - ARM Linux wrote: > On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote: > > Hello Stephen, > > > > Thanks a bunch for taking the time and reviewing this! > > > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > > > With MFD devices the clk properties may be contained in MFD (parent) DT > > > > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD > > > > subdevice not to MFD device (parent). Add > > > > devm_of_clk_add_hw_provider_parent to tackle this issue. > > > > > > > > Also clkdev registration lacks of managed registration functions and it > > > > seems few drivers do not drop clkdev lookups at exit. Add > > > > devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup > > > > releasing at exit. > > > > > > Please split this into clkdev and non-clkdev devm functionality. > > Allright. I'll split this to two patches. > > Definitely, please note that clkdev is separate from the common > clk stuff, and is actually maintained by a different person (me) > although I currently defer much of the review to the common clk > guys. Right. This clarifies how clkdev is maintained. Thanks for letting me know. Is it still Ok to do these changes through linux-clk tree or is there some other tree where the devm portion should be submitted? If so, how should the dependencies be handled? Br, Matti Vaittinen > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up -- Matti Vaittinen ROHM Semiconductors ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
