On Tue, Nov 20, 2018 at 05:07:29PM +0530, Sharat Masetty wrote: > The current implementation of ascii85_encode() does not copy the encoded > buffer 'z' to the output buffer in case the input is zero. This patch > simply adds this missing piece. This makes it easier to use this > function to encode large buffers. > > Signed-off-by: Sharat Masetty <smasetty@xxxxxxxxxxxxxx> Adding intel-gfx since they are the other consumers of this code but this seems legit to me. Jordan > --- > include/linux/ascii85.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h > index 4cc4020..00646fc 100644 > --- a/include/linux/ascii85.h > +++ b/include/linux/ascii85.h > @@ -23,8 +23,12 @@ > { > int i; > > - if (in == 0) > - return "z"; > + if (in == 0) { > + out[0] = 'z'; > + out[1] = '\0'; > + > + return out; > + } > > out[5] = '\0'; > for (i = 5; i--; ) { > -- > 1.9.1 > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project