Hi,
On Mon, Nov 19, 2018 at 4:58 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> On 20.11.2018 3:26, Douglas Anderson wrote:
> > In regulator_force_disable() there was a strange loop that looked like:
> >
> > while (rdev->open_count--)
> > regulator_disable(rdev->supply);
> >
> > I'm not totally sure what the goal was for this loop, but it seems
> > wrong to me. If anything I think maybe we should have been looping
> > over our use_count, but even that might be a little strange. For now
> > let's just remove the code and we can add something back in if someone
> > can explain what's expected.
> >
> > Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
>
> Seems this "fixes" tag is incorrect, isn't it? The "ww_mutex" patch didn't touch this code.
Yes, I think you're right. Originally I added it because I thought
that the "ww_mutex" patch should have touched this too, but I'm wrong.
I'll remove the "Fixes" tag if/when I send out v2.
-Doug
