Hi Jordan. > case COLOR_FMT_P010_UBWC: > - alignment = 256; > - stride = MSM_MEDIA_ALIGN(width * 2, alignment); > + stride = MSM_MEDIA_ALIGN(width * 2, 256); > break; > case COLOR_FMT_P010: > - alignment = 128; > - stride = MSM_MEDIA_ALIGN(width*2, alignment); > - break; > - default: > + stride = MSM_MEDIA_ALIGN(width*2, 128); As you touch this line, could you please add spaces around '*' Same goes for use of '/' in a few places. I assume checkpatch would have told you to fix this. With this fixed you can add my: Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Sam