On Sat, Nov 03, 2018 at 08:36:00AM +0530, Taniya Das wrote: > Hello Stephen, > > On 10/18/2018 5:02 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-11 04:36:01) > > > --- a/drivers/cpufreq/Kconfig.arm > > > +++ b/drivers/cpufreq/Kconfig.arm [...] > > > +static const u16 cpufreq_qcom_std_offsets[REG_ARRAY_SIZE] = { > > > > Is this going to change in the future? > > > > Yes, they could change and that was the reason to introduce the offsets. > This was discussed earlier too with Sudeep and was to add them. Sorry, I didn't like these registers to be coming from DT and I had the same question: will this keep changing ? And IIRC, the answer was yes. But I agree with Stephen, if and when we see the change, you can introduce the array and keep it simple until then. -- Regards, Sudeep