Quoting Jordan Crouse (2018-10-25 09:38:11)
> The real llcc_slide_getd() function returns ERR_PTR() encoded errors
> so the stub function should too.
>
> Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>
> ---
> include/linux/soc/qcom/llcc-qcom.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
> index eb71a50b8afc..e9806d548834 100644
> --- a/include/linux/soc/qcom/llcc-qcom.h
> +++ b/include/linux/soc/qcom/llcc-qcom.h
> @@ -171,7 +171,7 @@ int qcom_llcc_remove(struct platform_device *pdev);
> #else
> static inline struct llcc_slice_desc *llcc_slice_getd(u32 uid)
> {
> - return NULL;
> + return ERR_PTR(-ENODEV);
Do you want it to be an error if your driver uses this API and doesn't
get the pointer it was requesting? Typically if a framework isn't
compiled in, and it isn't essential to the operation of the device, it
makes sense to NOP out the API by returning NULL instead of an error.
Then drivers only check for error pointers and treat the NULL pointer as
a cookie meaning "do nothing".
