From: Sean Paul <seanpaul@xxxxxxxxxxxx> state->connector is just a backpointer to conn with the added risk of state being NULL. Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 82c55efb500f..05015d5ae3d2 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1044,7 +1044,7 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, phys->hw_pp = dpu_enc->hw_pp[i]; phys->hw_ctl = hw_ctl[i]; - phys->connector = conn->state->connector; + phys->connector = conn; if (phys->ops.mode_set) phys->ops.mode_set(phys, mode, adj_mode); } -- Sean Paul, Software Engineer, Google / Chromium OS