On Fri, Oct 5, 2018 at 12:38 PM Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx> wrote: > > Hi Rob > > Had one question on below comment. Can you please help to clarify? > > Thanks > > Abhinav > On 2018-10-04 12:42, Abhinav Kumar wrote: > > Hi Rob > > > > Thanks for the review. Will copy the DT list in the next patchset. > > > > Some comments inline. > > > > Thanks > > > > Abhinav > > > > On 2018-10-04 12:01, Rob Herring wrote: > >> If you want DT bindings reviewed, you have to cc the DT list. (Or wait > >> for Sean Paul to ping me on IRC) > >> > >> On Fri, Sep 28, 2018 at 7:39 PM Abhinav Kumar [...] > >>> +- reset-gpios: phandle of gpio for reset line > >>> + This should be 8mA, gpio can be configured using mux, pinctrl, > >>> pinctrl-names > >>> + (active low) > >>> +- mode-gpios: phandle of the gpio for choosing the mode of the > >>> display > >>> + for single DSI or Dual DSI > >>> + (active high) > >> > >> active high doesn't really make sense for this. > > Alright, will remove this. > Here you would prefer us to make this GPIO active low right? No, because both states are active. > OR you were just mentioning that I can remove the active high > documentation? Correct. Rob
