On Thu 06 Sep 10:52 PDT 2018, Doug Anderson wrote: > Bjorn, > > On Sat, Sep 1, 2018 at 3:19 PM, Bjorn Andersson > <bjorn.andersson@xxxxxxxxxx> wrote: > > Add regulator definitions for pm8998 and pmi8998 regulators on the MTP. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 216 ++++++++++++++++++++++++ > > 1 file changed, 216 insertions(+) > > I'm curious why you chose to post this instead of reviewing and/or > building upon the patch I sent up at > <https://lkml.kernel.org/r/20180822173629.202885-3-dianders@xxxxxxxxxxxx>. Sorry about that, my search skills failed me. > Compared to mine, yours: > > * Seems to have a few rails named differently LDO22 is named > "vreg_l22a_2p95" in your DTS but "vreg_l22a_2p85" in mine as one > example. The schematics I have (from Dec 5, 2017) show it as 2p85. > Looks like a typo on my part, yours matches the schematics I have as well. > * Is missing "regulator-initial-mode". We can debate this if you want. > Either we start by making them all HPM or we tune as we debug, I'm fine with your suggestion. > * Is lacking many alternate names for rails. We can debate this also > if you want. > Afaict names such as "vdda_pcie_1p2" is the name of the pin on the SDM845, while the thing that comes out of the regulator is named vreg_l26a_1p2. So I believe this name should be used in the pcie node as: vdda_pcie_1p2-supply = <&vreg_l26a_1p2>; > * Have a few voltage values different. If you have better info than > me we should update to yours. Diffing against yours does make me > believe that perhaps LDO14 should be listed as 1.88 V in my patch. > Downstream it's listed as min: 1.8V max: 1.88V init: 1.8V. > * Is lacking pm8005. > I didn't need this, yet... > Anyway, let me know. If you provide a review of my patch I'm happy to > spin it with your feedback. > I will review your patches. Regards, Bjorn
