On 2018-08-24 14:27, Stanimir Varbanov wrote:
Hi Alex,
On 08/24/2018 10:38 AM, Alexandre Courbot wrote:
On Thu, Aug 23, 2018 at 11:29 PM Vikash Garodia
<vgarodia@xxxxxxxxxxxxxx> wrote:
[snip]
index c4a5778..a9d042e 100644
--- a/drivers/media/platform/qcom/venus/firmware.c
+++ b/drivers/media/platform/qcom/venus/firmware.c
@@ -22,10 +22,43 @@
#include <linux/sizes.h>
#include <linux/soc/qcom/mdt_loader.h>
+#include "core.h"
#include "firmware.h"
+#include "hfi_venus_io.h"
#define VENUS_PAS_ID 9
#define VENUS_FW_MEM_SIZE (6 * SZ_1M)
This is making a strong assumption about the size of the FW memory
region, which in practice is not always true (I had to reduce it to
5MB). How about having this as a member of venus_core, which is
Why you reduced to 5MB? Is there an issue with 6MB or you don't want to
waste reserved memory?
initialized in venus_load_fw() from the actual size of the memory
region? You could do this as an extra patch that comes before this
one.
I would go with existing design than relying on the size specified in
the
memory-region for venus. size loaded is always taken from DT while the
VENUS_FW_MEM_SIZE serves the purpose of sanity check.
The size is 6MB by historical reasons and they are no more valid, so I
think we could safely decrease to 5MB. I could prepare a patch for
that.
Thanks Stan. Initial patch in this series had 5MB. We discussed earlier
to keep
it as is and take it as a separate patch to update from 6MB to 5MB.
