On 20-08-18, 13:18, Rob Herring wrote: > On Mon, Aug 20, 2018 at 12:09:52PM +0530, Vinod Koul wrote: > > +PROPERTIES: > > + > > +- compatible: > > + Usage: required > > + Value type: <string> > > + Definition: must be one of: > > + "qcom,msm-8916-cci" > > + "qcom,msm-8996-cci" > > I think everywhere else is 'msm8916' and 'msm8996'. Quick grep told me that is the case, so will update. > > +SUBNODES: > > + > > +The CCI provides I2C masters for one or two i2c busses, described as > > +subdevices named "i2c-bus0" and "i2c-bus1". > > Use a unit-address and reg property with 0 and 1 here. Am not sure I understood that properly, still learning DT nuisances, care to elaborate a bit please. > With those fixed, > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Great, thanks for the review. -- ~Vinod
