Hi, On Wed, Aug 15, 2018 at 4:13 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Tue, Aug 14, 2018 at 04:56:42PM -0700, Doug Anderson wrote: > >> IMO about the best we could hope to do would be to map "mode" from >> children to parent. AKA: perhaps you could assume that if a child is >> in a higher power mode that perhaps a parent should be too? > > That's not going to work well - different regulators have wildly > different abilities to deliver current which is the whole reason why > modes are so fuzzy and hard to use in the first place. A high power > load for a low noise regulator designed to feed analogue circuits might > not even make it out of the lowest power LDO mode of a DCDC designed to > supply the main application processors in the system or (more > relevantly) provide the main step down for a bunch of LDOs. OK, fair enough. I'll drop this patch and rebase the later patches in the series without it since I think they're still useful. I'll work on either adding more regulator_set_load() calls to clients or perhaps disabling the "regulator-allow-set-load" for a bunch of rails. David: presumably if we have a rail that we never need to be on-and-in-low-power-mode can just be left in high power mode all the time? There should be no advantage of being in low power mode for a regulator that is off, right? -Doug