On Thu, Jul 26, 2018 at 4:30 PM, Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote: > I made a silly little script that looked at the defined symbols > in nm and then looked to see if other files in the module used > those symbols and if they didn't they were either candidates > for removal or to be made static. This is the result. > > I split the code into per-file chunks for easier review and > to make it easier for the developers to object to any given removal > but I have no qualms if Sean or Rob want to squash these together > in the final patch. nice, I was wishing for such a script the other day when I noticed a few unused things.. I'm ok to leave these unsquashed.. I guess in the best case that makes it easier to resurrect appropriate hunks if they become un-dead in the future.. BR, -R > > Jordan Crouse (5): > drm/msm/disp/dpu: Remove unused code from drm_encoder.c > drm/msm/disp/dpu: Remove unused code from drm_crtc.c > drm/msm/disp/dpu: Remove dpu_kms_utils > drm/msm/disp/dpu: Remove unused functions from dpu_formats.c > drm/msm/disp/dpu: Mark a handful of functions as static > > drivers/gpu/drm/msm/Makefile | 1 - > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 383 +----------------- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 61 --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 87 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 14 - > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 23 -- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 48 --- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 84 ---- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 10 - > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 112 ----- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 153 ------- > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 2 +- > 18 files changed, 15 insertions(+), 1018 deletions(-) > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c > > -- > 2.18.0 > > _______________________________________________ > Freedreno mailing list > Freedreno@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/freedreno -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html