Hi, On Fri, Jul 20, 2018 at 3:53 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> + mas->oversampling = 1; >> + /* Transmit an entire FIFO worth of data per IRQ */ >> + mas->tx_wm = 1; >> + geni_se_get_wrapper_version(se, major, minor, step); > > In v1 Stephen said: > >> Drop extra parenthesis. > > I'll further add that I'd prefer it if you based your series atop > <https://patchwork.kernel.org/patch/10412417/> which changes the > prototype here. Whoops. Extra parenthesis was actually referring to the line below this one, AKA: > + if ((major == 1) && (minor == 0)) > + mas->oversampling = 2; ...that still applies. ...but then ignore my comment suggesting that you base your series atop Stephen's. You already did that. Certainly you should mention somewhere in your email that your patch is based on his. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
