Hi,
On Fri, Jul 13, 2018 at 9:00 AM, Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> Quoting Matthias Kaehlcke (2018-07-09 14:25:21)
>> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
>> index 92bed1e7d4bb..7eea94701b23 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
>> @@ -11,6 +11,13 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> + pm8998_temp: temp-alarm@2400 {
>
> Are we sorting this file based on node name or unit address? Otherwise
> patch looks good.
My preference would be:
* Anything where we're defining a new node with an address: sort by the address.
* If we are defining nodes without addresses: sort by node name (not by label!)
* In general I'd prefer to see addressless things before things with addresses.
* If we are overriding nodes that were defined in a parent makefile:
sort by the name of the parent label we refer to.
...so I think Matthias's sort order in this case is correct / consistent.
-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
