Am Dienstag, 3. Juli 2018, 08:04:31 CEST schrieb Vinod Koul: Hi Vinod, > +static int qcom_rng_read(struct qcom_rng *rng, void *data, size_t max) > +{ > + size_t currsize = 0; > + u32 *retdata = data; How can you be sure that this cast is appropriate? I.e. how is it guaranteed that data is 4-byte aligned? Also, the data variable in qcom_rng_generate is a u8 -- shouldn't this type be used instead of a void? Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html