On Thu, Jun 28, 2018 at 02:28:55PM -0400, Sean Paul wrote: > This time the iomap/iounmap helper functions. Move map into dpu and > refactor it to reflect their actual use. iounmap wasn't useful, so > delete it and call iounmap directly. > > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 38 +++++++++++++++++------- > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 13 ++++++-- > drivers/gpu/drm/msm/msm_drv.c | 23 -------------- > drivers/gpu/drm/msm/msm_drv.h | 2 -- > 4 files changed, 38 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 0b813a089cba..beba919a6ef6 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -77,6 +77,25 @@ bool dpu_is_custom_client(void) > return dpucustom; > } > > +static unsigned long dpu_iomap_size(struct platform_device *pdev, > + const char *name) > +{ > + struct resource *res; > + > + if (!name) { > + DRM_ERROR("Resource name unspecified\n"); > + return 0; > + } Maybe Just a WARN instead - a custom string isn't needed for a case that will never happen outside of developer error. <snip> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html