Quoting Bjorn Andersson (2018-06-22 09:54:54) > On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > > > This macro doesn't work, because it hides a local variable inside of the > > macro to hold the version and that variable name is called 'ver' and > > 'version' sometimes. > > > > Let's change this to be more explicit. Introduce three macros for the > > major, minor, and step of the version, and require callers to pass the > > version in to get the part of the version out. This way we don't hide > > local variables inside macros and things are less evil overall. > > > > Cc: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx> > > Cc: Sagar Dharia <sdharia@xxxxxxxxxxxxxx> > > Cc: Girish Mahadevan <girishm@xxxxxxxxxxxxxx> > > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > I was expecting that someone referenced this macro, but I guess that's > coming? The SPI driver does. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
