On Mon, Jun 18, 2018 at 08:48:32AM -0600, Rob Herring wrote: > On Mon, Jun 18, 2018 at 6:39 AM, Niklas Cassel <niklas.cassel@xxxxxxxxxx> wrote: > > On Mon, Jun 18, 2018 at 12:06:42PM +0100, Mark Brown wrote: > >> On Thu, Jun 14, 2018 at 01:11:36PM +0200, Niklas Cassel wrote: > >> > of_platform_device_destroy is only defined when building > >> > with CONFIG_OF=y. Add a depends on OF. > >> > >> Is it sensible that of_platform_device_destroy() is only defined when > >> building with CONFIG_OF=y? > > > > I'm redirecting that question to the device tree maintainers. > > > > There are a few of_* functions in include/linux/of_platform.h > > that are only defined when CONFIG_OF=y: > > > > of_platform_device_create() > > of_platform_device_destroy() > > of_platform_bus_probe() > > of_device_alloc() > > > > Rob, Frank, do you want me to create static inline dummy versions of these? > > No, because generally you should not be using these functions > directly. Yes, there are some users, but if you look at the tree, > there are few or isolated (PowerPC) users. Using > of_platform_populate/of_platform_depopulate is preferred. of_platform_device_destroy() is also used by sound/soc/qcom/qdsp6/* which is why I suggested this patch: https://marc.info/?l=alsa-devel&m=152932497413567 that adds "depends on OF" for SND_SOC_QDSP6 in sound/soc/qcom/Kconfig. Or do you think that a better solution would be to modify sound/soc/qcom/qdsp6/* so that it instead uses of_platform_populate()/of_platform_depopulate()? (Or perhaps this isn't even an option, I'm not at all familiar with the QDSP6 code). Regards, Niklas -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
