Re: [PATCH v7 8/8] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Balakrishna Godavarthi (2018-06-15 23:27:18)
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 28ae6a17a595..1961e313aae7 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1031,9 +1145,118 @@ static struct hci_uart_proto qca_proto = {
>         .dequeue        = qca_dequeue,
>  };
>  
> +static const struct qca_vreg_data qca_cherokee_data = {
> +       .soc_type = QCA_WCN3990,
> +       .vregs = (struct qca_vreg []) {
> +               { "vddio",   1352000, 1352000,  0 },
> +               { "vddxtal", 1904000, 2040000,  0 },
> +               { "vddcore", 1800000, 1800000,  1 },
> +               { "vddpa",   1304000, 1304000,  1 },
> +               { "vddldo",  3000000, 3312000,  1 },

Load of 0 and 1 seems sort of odd. Are these made up to indicate "some
load" vs. "no load"?

> +       },
> +       .num_vregs = 5,
> +};
> +
> +static int qca_enable_regulator(struct qca_vreg vregs,
> +                               struct regulator *regulator)
> +{
> +       int ret;
> +
> +       ret = regulator_set_voltage(regulator, vregs.min_uV,
> +                                   vregs.max_uV);
> +       if (ret)
> +               goto out;

Just return ret;

> +
> +       if (vregs.load_uA)
> +               ret = regulator_set_load(regulator,
> +                                        vregs.load_uA);
> +
> +       if (ret)
> +               goto out;
> +

Same.

> +       ret = regulator_enable(regulator);
> +
> +out:
> +       return ret;

And make this return regulator_enable(regulator).

> +
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux