Hi Abhishek, On Thu, 3 May 2018 17:50:29 +0530, Abhishek Sahu <absahu@xxxxxxxxxxxxxx> wrote: > Now, the NAND base layer has helper function for ecc > parameters setup which does the same thing. Even if this message has a meaning in the series, I would prefer something more generic like: "Use the NAND core helper function xxx() to tune the ECC parameters instead of the function locally defined." With this change: Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> Thanks, Miquèl -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html