On Thu, May 17, 2018 at 10:10 AM, <kgunda@xxxxxxxxxxxxxx> wrote: > On 2018-05-17 18:01, Rob Herring wrote: >> >> On Thu, May 17, 2018 at 4:47 AM, <kgunda@xxxxxxxxxxxxxx> wrote: >>> >>> On 2018-05-08 15:55, kgunda@xxxxxxxxxxxxxx wrote: >>>> >>>> >>>> On 2018-05-07 21:50, Bjorn Andersson wrote: >>>>> >>>>> >>>>> On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: >>>>> >>>>>> WLED4 peripheral is present on some PMICs like pmi8998 >>>>>> and pm660l. It has a different register map and also >>>>>> configurations are different. Add support for it. [...] >>>>>> + value: >>>>>> + For pm8941: from 0 to 25000 with 5000 ua step >>>>>> + Default 20000 uA >>>>>> + For pmi8998: from 0 to 30000 with 5000 ua step >>>>>> + Default 25000 uA. >>>>> >>>>> >>>>> >>>>> These values could be described just as well in mA, so keep the >>>>> original >>>>> unit - in particular since the boot-limit is in mA... >>>>> >>>> Ok. Will keep the original as is in the next series. >>> >>> >>> Here, I may have to go with the approach as in "qcom,ovp". Because for >>> pm8941 >>> the current step is 1 mA (I have wrongly mentioned as 5000uA here) and >>> for >>> PMI8998 >>> the current step is 2.5 mA. Hence, I will add another variable >>> "qcom,current-limit-ua" >>> just like "qcom,ovp-mv". >> >> >> Use unit suffixes defined in bindings/property-units.txt. > > Thanks for pointing it ! hope I can use "qcom,current-limit-microamp" and > "qcom,ovp-millivolt". I am asking this because i found only "-microvolt". > "-millivolt" is not present in the bindings you pointed. That's by design so everyone doesn't just pick whatever random units they like. Does microvolts not give you enough range? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
