On 2018-05-14 18:11, Joe Perches wrote: > On Mon, 2018-05-14 at 16:53 +0200, Peter Rosin wrote: >> Hi! >> >> The nice little inline i2c_8bit_addr_from_msg is not getting >> enough use. This series improves the situation and drops a >> bunch of lines in the process. > > Perhaps the inline should test for I2C_M_REV_DIR_ADDR > as there is at least one use like > > - addr = msg->addr << 1; > - if (flags & I2C_M_RD) > - addr |= 1; > + addr = i2c_8bit_addr_from_msg(msg); > if (flags & I2C_M_REV_DIR_ADDR) > addr ^= 1; > > which look odd I say no, because the driver has to also indicate support with I2C_FUNC_PROTOCOL_MANGLING and I don't see a sane way to check that part of the contract. But what do I know. Seems orthogonal. > Do any of these changes now no longer need > the temporary flags variable? Right, I thought I had made any obvious further simplification made possible by these changes, but I overlooked that one. The flags variable is certainly over-engineered in i2c-algo-pcf.c and would be a good candidate for removal. But that's only patch 3/21. I'll wait for a bit with an update, and Wolfram can adjust this on the way in if he feels like it. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
