On 07-05-18, 14:52, Thierry Escande wrote:
> For a given frequency and prop_name, if a voltage supply entry is
> missing in the opp-table defined in DT, the frequency was added anyway
> to the opp tables with a voltage setting of 0.
>
> With this patch, if a prop_name is set, frequencies with no
> corresponding prop_name are ignored without failing.
>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxx>
> ---
>
> For Qualcomm apq8064 SoCs, the opp-tables defined in the dts file
> contain all frequencies supported by all SoC versions. But not all SoCs
> support all frequencies and they are filtered out by a prop_name
> containing a speed bin value and a pvs value both read from a fuse
> register sets in factory. The speed bin defines the SoC version and the
> voltage setting is defined by the pvs value in the form:
>
> opp-384000000 {
> opp-hz = /bits/ 64 <384000000>;
> opp-microvolt-speed0-pvs0-v0 = <950000>;
> opp-microvolt-speed0-pvs1-v0 = <900000>;
> ...
> opp-microvolt-speed1-pvs0-v0 = <950000>;
> opp-microvolt-speed1-pvs1-v0 = <950000>;
> ...
> opp-microvolt-speed2-pvs0-v0 = <950000>;
> opp-microvolt-speed2-pvs1-v0 = <950000>;
> opp-microvolt-speed2-pvs2-v0 = <925000>;
> opp-microvolt-speed2-pvs3-v0 = <900000>;
> ...
> };
That's not right.
We shouldn't be overriding the prop-name feature to discard frequencies. We
already have a special feature (which was added just for qcom to begin with)
which much be used here: "opp-supported-hw".
So you have to use "opp-supported-hw" for ignoring few of the OPP nodes on
specific hardware platforms and "prop-name" for selecting the right
voltage/current on them.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
