Hi Balakrishna, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on next-20180504] [cannot apply to bluetooth/master v4.17-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Balakrishna-Godavarthi/dt-bindings-net-bluetooth-Add-device-tree-bindings-for-QTI-chip-wcn3990/20180506-004430 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: x86_64-randconfig-x017-201818 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers//bluetooth/hci_qca.c: In function 'qca_open': drivers//bluetooth/hci_qca.c:512:4: error: implicit declaration of function 'btqca_power_setup'; did you mean 'ether_setup'? [-Werror=implicit-function-declaration] btqca_power_setup(true); ^~~~~~~~~~~~~~~~~ ether_setup drivers//bluetooth/hci_qca.c: In function 'qca_close': drivers//bluetooth/hci_qca.c:604:4: error: implicit declaration of function 'qca_btsoc_cleanup'; did you mean 'hci_sock_cleanup'? [-Werror=implicit-function-declaration] qca_btsoc_cleanup(hu->hdev); ^~~~~~~~~~~~~~~~~ hci_sock_cleanup drivers//bluetooth/hci_qca.c: In function 'qca_send_poweron_cmd': drivers//bluetooth/hci_qca.c:988:8: error: 'CHEROKEE_POWERON_PULSE' undeclared (first use in this function) cmd = CHEROKEE_POWERON_PULSE; ^~~~~~~~~~~~~~~~~~~~~~ drivers//bluetooth/hci_qca.c:988:8: note: each undeclared identifier is reported only once for each function it appears in drivers//bluetooth/hci_qca.c: In function 'qca_send_poweroff_cmd': drivers//bluetooth/hci_qca.c:1018:8: error: 'CHEROKEE_POWEROFF_PULSE' undeclared (first use in this function) cmd = CHEROKEE_POWEROFF_PULSE; ^~~~~~~~~~~~~~~~~~~~~~~ drivers//bluetooth/hci_qca.c: In function 'qca_setup': drivers//bluetooth/hci_qca.c:1144:9: error: implicit declaration of function 'rome_patch_ver_req'; did you mean 'blk_path_error'? [-Werror=implicit-function-declaration] ret = rome_patch_ver_req(hdev, &soc_ver); ^~~~~~~~~~~~~~~~~~ blk_path_error drivers//bluetooth/hci_qca.c:1182:9: error: implicit declaration of function 'qca_uart_setup_cherokee'; did you mean 'qca_uart_setup_rome'? [-Werror=implicit-function-declaration] ret = qca_uart_setup_cherokee(hdev, qca_baudrate, &soc_ver); ^~~~~~~~~~~~~~~~~~~~~~~ qca_uart_setup_rome drivers//bluetooth/hci_qca.c: At top level: drivers//bluetooth/hci_qca.c:1308:5: error: conflicting types for 'btqca_power_setup' int btqca_power_setup(bool on) ^~~~~~~~~~~~~~~~~ drivers//bluetooth/hci_qca.c:1309:1: note: an argument type that has a default promotion can't match an empty parameter name list declaration { ^ drivers//bluetooth/hci_qca.c:512:4: note: previous implicit declaration of 'btqca_power_setup' was here btqca_power_setup(true); ^~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:10:0, from drivers//bluetooth/hci_qca.c:31: drivers//bluetooth/hci_qca.c: In function 'btqca_power_setup': include/linux/compiler.h:58:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ >> drivers//bluetooth/hci_qca.c:1346:3: note: in expansion of macro 'if' if (vregs[i].load_ua) ^~ drivers//bluetooth/hci_qca.c:1349:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' btqca_disable_regulators(i+1, vregs); ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/if +1346 drivers//bluetooth/hci_qca.c 1307 1308 int btqca_power_setup(bool on) 1309 { 1310 int ret = 0; 1311 int i; 1312 struct btqca_vreg *vregs; 1313 1314 if (!qca || !qca->vreg_data || !qca->vreg_bulk) 1315 return -EINVAL; 1316 vregs = qca->vreg_data->vregs; 1317 1318 BT_DBG("on: %d", on); 1319 /* turn on if regualtors are off */ 1320 if (on == true && qca->vreg_status == false) { 1321 qca->vreg_status = true; 1322 for (i = 0; ret == 0 && i < qca->vreg_data->num_vregs; i++) { 1323 regulator_set_voltage(qca->vreg_bulk[i].consumer, 1324 vregs[i].min_v, 1325 vregs[i].max_v); 1326 1327 if (vregs[i].load_ua) 1328 regulator_set_load(qca->vreg_bulk[i].consumer, 1329 vregs[i].load_ua); 1330 1331 ret = regulator_enable(qca->vreg_bulk[i].consumer); 1332 } 1333 } else if (on == false && qca->vreg_status == true) { 1334 qca->vreg_status = false; 1335 /* turn of regualtor in reverse order */ 1336 btqca_disable_regulators(qca->vreg_data->num_vregs, vregs); 1337 } 1338 1339 /* regulatos fails to enable */ 1340 if (ret) { 1341 qca->vreg_status = false; 1342 BT_ERR("failed to enable regualtor:%s", vregs[i].name); 1343 /* set regulator voltage and load to zero */ 1344 regulator_set_voltage(qca->vreg_bulk[i].consumer, 1345 0, vregs[i].max_v); > 1346 if (vregs[i].load_ua) 1347 regulator_set_load(qca->vreg_bulk[i].consumer, 0); 1348 /* turn off regulators which are enabled */ 1349 btqca_disable_regulators(i+1, vregs); 1350 } 1351 1352 return ret; 1353 } 1354 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
