On Thursday 03 May 2018 11:13 PM, Christian Lamparter wrote:
On Mittwoch, 2. Mai 2018 14:14:39 CEST Linus Walleij wrote:
On Thu, Apr 26, 2018 at 11:47 PM, Christian Lamparter
<chunkeey@xxxxxxxxx> wrote:
On Thu, Apr 26, 2018 11:12:21 CEST Linus Walleij wrote:
I think I replied in some other mail that I think we need to
be backwards compatible and it's not too hard to do
both. (Correct me if I'm wrong.)
I think so too, I looked around and found that the nvidia pinctrl was
doing something similar with of_find_property():
<https://elixir.bootlin.com/linux/v4.17-rc2/source/drivers/pinctrl/tegra/pinctrl-tegra.c#L652>
| has_prop = of_find_property(np, "gpio-ranges", NULL);
However this looks kinda funny, since "has_prob" is declared as a bool
and of_find_property() returns a pointer to a "struct property"....
Tell you what: If nobody beats me to it, I'll sent a patch for this after
the pinctrl-msm's gpio-hog has been dealt with. :)
Yeah the nVidia driver is one of the oldest and also at the time
DT was kind of new. I haven't heard from Stephen for a while
but I bet he will pop up, else check with Laxman, he's got
a good grip on nVidia pinctrl+GPIO as well.
All in good time.
But first @Bjorn and @Andy or @David can you please look and
review v4 "pinctrl: msm: fix gpio-hog related boot issues"
<https://patchwork.kernel.org/patch/10339129/>
Agree with the patch as by adding gpio-ranges, we add the gpio range
part of gpiochip_add(), called by
of_gpiochip_add()->of_gpiochip_add_pin_range(). and so does not need to
explicitly call of the gpiochip_add_pin_range().
Please add ack in above patch.
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
