On Sat, Apr 28, 2018 at 07:28:17AM -0700, Sujeev Dias wrote: > Thanks for quick feedback > > > On 04/27/2018 12:22 AM, Greg Kroah-Hartman wrote: > > On Thu, Apr 26, 2018 at 07:23:28PM -0700, Sujeev Dias wrote: > > > MHI Host Interface is a communication protocol to be used by the host > > > to control and communcate with modem over a high speed peripheral bus. > > > This module will allow host to communicate with external devices that > > > support MHI protocol. > > > > > > Signed-off-by: Sujeev Dias <sdias@xxxxxxxxxxxxxx> > > No one else has ever reviewed this code before? That's not good, please > > at the very least, have someone else at your company go over it first. > > I don't want to be the ones having to point out all of the "obvious" > > issues :) > > > This code has gone thru rigorous code review and testing, before I submit > next patch I will have multiple people sign off on it. Thank you. > Intention was to completely compile out MHI_VERB messages because we have > those messages in data path. For release build, we wanted to reduce > as much mips as possible. However, for debugging these messages are > extremely helpful. That's exactly what dev_dbg() does today. So please use it. > I will look into tracepoints... Or that, if you want them, they can be useful on data paths. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
