Re: [PATCH v3 2/2] Bluetooth: Add support for wcn3990 soc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Balakrishna,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20180424]
[cannot apply to v4.17-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Balakrishna-Godavarthi/Enable-Bluetooth-functionality-for-WCN3990/20180426-103256
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-x000-201816 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from drivers//bluetooth/hci_qca.c:38:0:
   drivers//bluetooth/hci_qca.c: In function 'qca_serdev_open':
>> include/net/bluetooth/bluetooth.h:146:9: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
     BT_ERR("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
            ^
   include/net/bluetooth/bluetooth.h:136:33: note: in definition of macro 'BT_ERR'
    #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
                                    ^~~
>> drivers//bluetooth/hci_qca.c:1041:3: note: in expansion of macro 'bt_dev_err'
      bt_dev_err(hu->hdev, "%s:open operation not supported");
      ^~~~~~~~~~
   drivers//bluetooth/hci_qca.c:1041:26: note: format string is defined here
      bt_dev_err(hu->hdev, "%s:open operation not supported");
                            ~^
   drivers//bluetooth/hci_qca.c: In function 'qca_serdev_probe':
>> drivers//bluetooth/hci_qca.c:1334:7: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     data = of_device_get_match_data(&serdev->dev);
          ^
   drivers//bluetooth/hci_qca.c: In function 'btqca_power_setup':
>> drivers//bluetooth/hci_qca.c:1288:4: warning: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Wunused-result]
       regulator_enable(qca->vreg_bulk[i].consumer);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   drivers//bluetooth/btqca.c: In function 'cherokee_tlv_check_data':
>> drivers//bluetooth/btqca.c:154:13: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
      tlv_patch = (struct tlv_type_patch *)tlv->data;
                ^
   In file included from drivers//bluetooth/btqca.c:22:0:
   drivers//bluetooth/btqca.c: In function 'cherokee_download_firmware':
>> include/net/bluetooth/bluetooth.h:142:10: warning: too many arguments for format [-Wformat-extra-args]
     BT_INFO("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
             ^
   include/net/bluetooth/bluetooth.h:134:35: note: in definition of macro 'BT_INFO'
    #define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
                                      ^~~
>> drivers//bluetooth/btqca.c:408:2: note: in expansion of macro 'bt_dev_info'
     bt_dev_info(hdev, "wcn3990  Downloading", config->fwname);
     ^~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/bluetooth/hci_qca.c:38:0:
   drivers/bluetooth/hci_qca.c: In function 'qca_serdev_open':
>> include/net/bluetooth/bluetooth.h:146:9: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
     BT_ERR("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
            ^
   include/net/bluetooth/bluetooth.h:136:33: note: in definition of macro 'BT_ERR'
    #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
                                    ^~~
   drivers/bluetooth/hci_qca.c:1041:3: note: in expansion of macro 'bt_dev_err'
      bt_dev_err(hu->hdev, "%s:open operation not supported");
      ^~~~~~~~~~
   drivers/bluetooth/hci_qca.c:1041:26: note: format string is defined here
      bt_dev_err(hu->hdev, "%s:open operation not supported");
                            ~^
   drivers/bluetooth/hci_qca.c: In function 'qca_serdev_probe':
   drivers/bluetooth/hci_qca.c:1334:7: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     data = of_device_get_match_data(&serdev->dev);
          ^
   drivers/bluetooth/hci_qca.c: In function 'btqca_power_setup':
   drivers/bluetooth/hci_qca.c:1288:4: warning: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Wunused-result]
       regulator_enable(qca->vreg_bulk[i].consumer);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   drivers/bluetooth/btqca.c: In function 'cherokee_tlv_check_data':
   drivers/bluetooth/btqca.c:154:13: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
      tlv_patch = (struct tlv_type_patch *)tlv->data;
                ^
   In file included from drivers/bluetooth/btqca.c:22:0:
   drivers/bluetooth/btqca.c: In function 'cherokee_download_firmware':
>> include/net/bluetooth/bluetooth.h:142:10: warning: too many arguments for format [-Wformat-extra-args]
     BT_INFO("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
             ^
   include/net/bluetooth/bluetooth.h:134:35: note: in definition of macro 'BT_INFO'
    #define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
                                      ^~~
   drivers/bluetooth/btqca.c:408:2: note: in expansion of macro 'bt_dev_info'
     bt_dev_info(hdev, "wcn3990  Downloading", config->fwname);
     ^~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +146 include/net/bluetooth/bluetooth.h

e781b7f7 Szymon Janc    2015-09-16  140  
6f558b70 Loic Poulain   2015-08-30  141  #define bt_dev_info(hdev, fmt, ...)				\
6f558b70 Loic Poulain   2015-08-30 @142  	BT_INFO("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
594b31ea Frederic Danis 2015-09-23  143  #define bt_dev_warn(hdev, fmt, ...)				\
594b31ea Frederic Danis 2015-09-23  144  	BT_WARN("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
6f558b70 Loic Poulain   2015-08-30  145  #define bt_dev_err(hdev, fmt, ...)				\
6f558b70 Loic Poulain   2015-08-30 @146  	BT_ERR("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
6f558b70 Loic Poulain   2015-08-30  147  #define bt_dev_dbg(hdev, fmt, ...)				\
6f558b70 Loic Poulain   2015-08-30  148  	BT_DBG("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
6f558b70 Loic Poulain   2015-08-30  149  

:::::: The code at line 146 was first introduced by commit
:::::: 6f558b70fb39fc8272fc513ecf191b3ad87d867b Bluetooth: Add bt_dev logging macros

:::::: TO: Loic Poulain <loic.poulain@xxxxxxxxx>
:::::: CC: Marcel Holtmann <marcel@xxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux