As stated under "20) Conditional Compilation" in coding-style.rst. We shall rather use __maybe_unused than preprocessor macros in such cases. Signed-off-by: Pascal Huerst <pascal.huerst@xxxxxxxxx> --- drivers/tty/serial/msm_serial.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index cde22e7e540c..55ee70c108e3 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -1819,8 +1819,7 @@ static const struct of_device_id msm_match_table[] = { }; MODULE_DEVICE_TABLE(of, msm_match_table); -#ifdef CONFIG_PM_SLEEP -static int msm_serial_suspend(struct device *dev) +static int __maybe_unused msm_serial_suspend(struct device *dev) { struct msm_port *port = dev_get_drvdata(dev); @@ -1829,7 +1828,7 @@ static int msm_serial_suspend(struct device *dev) return 0; } -static int msm_serial_resume(struct device *dev) +static int __maybe_unused msm_serial_resume(struct device *dev) { struct msm_port *port = dev_get_drvdata(dev); @@ -1837,7 +1836,6 @@ static int msm_serial_resume(struct device *dev) return 0; } -#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops msm_serial_dev_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(msm_serial_suspend, msm_serial_resume) -- 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html