On 4/12/2018 4:30 PM, Matthias Kaehlcke wrote: >> @@ -675,9 +675,6 @@ static int get_tx_fifo_size(struct qcom_geni_serial_port *port) >> { >> struct uart_port *uport; >> >> - if (!port) >> - return -ENODEV; >> - > > With this get_tx_fifo_size() returns always 0, also the only caller > doesn't evaluate the return value. Change to void? > Yes, I will change the return to void. Regards, Karthik. -- Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html