On 13 April 2018 at 17:05, Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Thu, Apr 12, 2018 at 6:14 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> The CPU's idle state nodes are currently parsed at the common cpuidle DT >> library, but also when initializing back-end data for the arch specific CPU >> operations, as in the PSCI driver case. >> >> To avoid open-coding, let's introduce of_get_cpu_state_node(), which takes >> the device node for the CPU and the index to the requested idle state node, >> as in-parameters. In case a corresponding idle state node is found, it >> returns the node with the refcount incremented for it, else it returns >> NULL. >> >> Moreover, for ARM, there are two generic methods, to describe the CPU's >> idle states, either via the flattened description through the >> "cpu-idle-states" binding [1] or via the hierarchical layout, using the >> "power-domains" and the "domain-idle-states" bindings [2]. Hence, let's >> take both options into account. >> >> [1] >> Documentation/devicetree/bindings/arm/idle-states.txt >> [2] >> Documentation/devicetree/bindings/arm/psci.txt >> >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx> >> Suggested-by: Sudeep Holla <sudeep.holla@xxxxxxx> >> Co-developed-by: Lina Iyer <lina.iyer@xxxxxxxxxx> >> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> --- >> drivers/of/base.c | 35 +++++++++++++++++++++++++++++++++++ >> include/linux/of.h | 8 ++++++++ >> 2 files changed, 43 insertions(+) > > Some reason you didn't add my Reviewed-by from v6? No, I was just sloppy. My apologies! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html