On 28 March 2018 at 17:22, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > Currently the error pointer returned by msm_alloc_stolen_fb gets passed > to drm_framebuffer_remove. The latter handles only NULL pointers, thus > a nasty crash will occur. > > Drop the unnecessary fail label and the associated checks - both err and > fb will be set at this stage. > > Cc: Rob Clark <robdclark@xxxxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > --- > v2: really remove the fail label :-\ > --- Humble ping? -Emil -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html