On 3/27/2018 10:50 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +#include "qcom-ipq4019.dtsi" >> +#include <dt-bindings/input/input.h> >> +#include <dt-bindings/gpio/gpio.h> >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK07.1"; >> + compatible = "qcom,ipq4019"; > > The board should set these, so you shouldn't need to specify them here. > And you should be able to find a more specific compatible for the board. > ok. agree. As mentioned earlier, will correct the compatible in all boards. >> + > [..] >> + qpic-nand@79b0000 { >> + status = "ok"; > > No pinmux for the qpic on these boards? > clearly missed it and was lucky that bootloader was doing it in this case. Will add it. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html