Re: [PATCH] i2c: qup: Add shutdown method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 19, 2018 at 10:18 AM, Christ, Austin
<austinwc@xxxxxxxxxxxxxx> wrote:
>> What's the problem with not handling this IRQ? Does the hardware end up
>> in some funky state? Are you worried that the kexec kernel will not
>> function because there's a pending I2C interrupt?
>>
> The potential issue is that if an IRQ is left high, the secondary kernel
> driver for I2C may enter a bad state trying to handle an interrupt that does
> not apply to its context. In the QUP driver case, it may be less of an issue
> because the probe does a soft reset of the core.

Bjorn, do you still have any concerns about this patch?  It seems like
the right thing to do, but I want to make sure you're satisified with
it, and whether it will be accepted for 4.17.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux