Hi Bjorn, On 03/19/2018 06:50 AM, Bjorn Andersson wrote: > On Fri 09 Mar 13:09 PST 2018, Georgi Djakov wrote: >> diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > [..] >> +Required properties: >> +- compatible : contains the interconnect provider vendor specific compatible >> + string >> +- reg : register space of the interconnect controller hardware > > These properties doesn't relate to the interconnect provider, so there's > no need to describe them here. Agree. > >> + >> +Examples: >> + >> + snoc: snoc@580000 { > > These nodes should be described in a qcom/msm8916 binding document. Ok, will move this and the above to the platform specific binding documentation. > >> + compatible = "qcom,msm8916-snoc"; >> + reg = <0x580000 0x14000>; >> + clock-names = "bus_clk", "bus_a_clk"; >> + clocks = <&rpmcc RPM_SMD_SNOC_CLK>, <&rpmcc RPM_SMD_SNOC_A_CLK>; >> + status = "okay"; >> + }; Thanks for the comments! BR, Georgi -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html