On 3/16/2018 12:30 PM, Alexander Duyck wrote: > On Fri, Mar 16, 2018 at 9:16 AM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: >> Code includes wmb() followed by writel(). writel() already has a >> barrier on some architectures like arm64. >> >> This ends up CPU observing two barriers back to back before executing >> the register write. >> >> Since code already has an explicit barrier call, changing writel() to >> writel_relaxed(). >> >> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx> > > You can update the writel call in fm10k_tx_map as well. > > Of the drivers updated in drivers/net/ethernet/intel/* it looks like > this is the only one that still requires any additional changes. will do. thanks for the feedback. > > Thanks. > > - Alex > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
