On 3/16/2018 4:17 PM, Abhishek Sahu wrote:
> On 2018-03-16 15:08, Sricharan R wrote:
>> Add serial, i2c, bam, spi, qpic peripheral nodes.
>>
>> Signed-off-by: Sricharan R <sricharan@xxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 105 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 105 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> index 2bc5dec..806fc56 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> @@ -124,6 +124,111 @@
>> clock-names = "core", "iface";
>> status = "disabled";
>> };
>> +
>> + blsp_dma: dma@7884000 {
>> + compatible = "qcom,bam-v1.7.0";
>> + reg = <0x07884000 0x2b000>;
>
> we can remove leading zero. s/0x07884000/0x7884000
>
>> + interrupts = <GIC_SPI 238 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_BLSP1_AHB_CLK>;
>> + clock-names = "bam_clk";
>> + #dma-cells = <1>;
>> + qcom,ee = <0>;
>> + };
>> +
>> + serial_blsp0: serial@78af000 {
>> + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
>> + reg = <0x78af000 0x200>;
>> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_BLSP1_UART1_APPS_CLK>,
>> + <&gcc GCC_BLSP1_AHB_CLK>;
>> + clock-names = "core", "iface";
>> + status = "disabled";
>> + };
>> +
>> + serial_blsp2: serial@78B1000 {
>
> For maintaining uniformity, we can have all address in lower case
> s/78B1000/78b1000
>
>> + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
>> + reg = <0x78B1000 0x200>;
>
> same thing, here also
>
>> + interrupts = <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_BLSP1_UART3_APPS_CLK>,
>> + <&gcc GCC_BLSP1_AHB_CLK>;
>> + clock-names = "core", "iface";
>> + dmas = <&blsp_dma 4>,
>> + <&blsp_dma 5>;
>> + dma-names = "tx", "rx";
>> + status = "disabled";
>> + };
>> +
>> + spi_0: spi@78b5000 {
>> + compatible = "qcom,spi-qup-v2.2.1";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x78b5000 0x600>;
>> + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
>> + spi-max-frequency = <50000000>;
>> + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>,
>> + <&gcc GCC_BLSP1_AHB_CLK>;
>> + clock-names = "core", "iface";
>> + dmas = <&blsp_dma 12>, <&blsp_dma 13>;
>> + dma-names = "tx", "rx";
>> + status = "disabled";
>> + };
>> +
>> + i2c_0: i2c@78b6000 {
>> + compatible = "qcom,i2c-qup-v2.2.1";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x78b6000 0x600>;
>> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_BLSP1_AHB_CLK>,
>> + <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
>> + clock-names = "iface", "core";
>> + clock-frequency = <400000>;
>
> remove one extra space. clock-frequency = <400000>;
>
>> + dmas = <&blsp_dma 15>, <&blsp_dma 14>;
>> + dma-names = "rx", "tx";
>> + status = "disabled";
>> + };
>> +
>> + i2c_1: i2c@78b7000 {
>> + compatible = "qcom,i2c-qup-v2.2.1";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x78b7000 0x600>;
>> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_BLSP1_AHB_CLK>,
>> + <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>;
>> + clock-names = "iface", "core";
>> + clock-frequency = <100000>;
>
> remove one extra space. clock-frequency = <100000>;
>
> with above changes.
>
> Reviewed-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>
>
Sure, will take care of all the above. Thanks
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
